Magisk reports ambiguous error for invalid module zip

topjohnwu / Magisk

The Magic Mask for Android

GNU General Public License v3.0

49.09k stars 12.62k forks source link

Magisk reports ambiguous error for invalid module zip #8579

Open mokurin000 opened 3 days ago

mokurin000 commented 3 days ago

Device: POCO F2 Pro Android version: 14 Magisk version name: 070719db Magisk version code: 28001

When try to install a module without META-INF/com/google/android/updater-script (mis-typed as update-script), Magisk just complains '!Unzip error', no useful error hint was given.

canyie commented 3 days ago

Yeah, I agree that we should print something more useful. Related code:

https://github.com/topjohnwu/Magisk/blob/b32d7bfafd2da3092ecc4720fd9fd1e3c041a808/app/core/src/main/java/com/topjohnwu/magisk/core/tasks/FlashZip.kt#L50-L62

aviraxp commented 3 days ago

https://github.com/topjohnwu/Magisk/pull/8416