topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
47.23k stars 11.96k forks source link

Unreliable MagiskHide Process Monitor #907

Closed topjohnwu closed 5 years ago

topjohnwu commented 5 years ago

For some people, the MagiskHide process monitor is not 100% reliable, which leads to random root detections on hidden apps.

lialosiu commented 5 years ago

Until now, All the devices report this issue is Oneplus...

Maybe some special things in Oneplus H2OS/OOS system?

paarnoutse commented 5 years ago

An XDA user reported at https://forum.xda-developers.com/showpost.php?p=78498587&postcount=29972 that disabling "phone" permission for Google Play made it working for him/her.

I didn't check this myself (I currently reverted to a previous Magisk version to prevent root detections), but possibly a useful tip for finding the reason for the issue in Magisk v18.

Update 2019-01-02: Tested the suggestion above in Magisk v18 now, but unfortunately doesn't work for me.

hkalltheway commented 5 years ago

Not only oneplus it seems. I am having this issue with the Galaxy Note 9. Also, I don't know if it's related, but everytime I open outlook, safetynet check fails until I restart the device

Madis0 commented 5 years ago

Fails on 9.0 OmniROM (OnePlus 5T) - Response payload validation failed. Play Store is certified. Worked on previous OmniROM and Magisk.

stargazer39 commented 5 years ago

My problem was disabling magskhide after minutes enabling it... It was 17.1 What I did was i removed some apps and kept 3 to 4 apps only in magiskhide list... It worked... After flashing uninstaller zip and then again installing 18.0 it works for me grate now.. Im on miui 10 Whyred.... (8.1.0 oreo)

null4n commented 5 years ago

An XDA user reported at https://forum.xda-developers.com/showpost.php?p=78498587&postcount=29972 that disabling "phone" permission for Google Play made it working for him/her.

I didn't check this myself (I currently reverted to a previous Magisk version to prevent root detections), but possibly a useful tip for finding the reason for the issue in Magisk v18.

Thanks a lot, this works for me. After clear play store user data and disable it's phone permission, all the safetynet detect app now can be shown as before (version 17.1)

zt-chen commented 5 years ago

this problem occur on my phone after Magisk was upgraded to 18.0. After using the phone for a while, it can not pass SaftNet. However, After cleaning back ground process, MagiskHide works again.

MagiskHide works find with Magisk Version17.1

ROM MIUI GLOBAL 10.0 Phone MI 6 Magisk version 18.0

xingoxu commented 5 years ago

Fail on Pixel 3 after running for a while

sfai05 commented 5 years ago

Fail on Pixel 3 after running for a while

Same here. Reverted back to Magisk 17.3 and it works fine

DocJaat commented 5 years ago

I am using Oneplus 5 running Oxygen OS Pie. I had no problems with Magisk 17.1 on Oreo but since dirty flashing to Pie and also updating Magisk to Version 18 - I am finding that Safetynet passed initially - after phone is in standby for some time - safetynet fails (both ctsProfile & basicIntegerity) - after reboot safetynet passes again. Also if I go to Magisk Manager and turn off Magisk Hide and switch it back on again - then the Safetynet paases again - only for sometime - after standby it fails again. Any solution?

hamid-elaosta commented 5 years ago

On a OnePlus 6T. Doesn't work with 18.0, works fine after flashing back to 17.3.

On 18.0 it appears to be intermittent; after a reboot, SafetyNet will pass for a little while, then it will not until another reboot. I'll stick with 17.3 for now.

xksefa commented 5 years ago

I've the same issue with Galaxy S7Edge. Android 8.0.0. Stock ROM. I need to disable MagiskHide and Re-Enable it to make it worked properly.

scottismyname commented 5 years ago

I can confirm that disabling and enabling Magisk Hide fixes this. Is there a way to do this via the command line? I would like to setup a tasker profile to do this. On my Pixel 2 XL I am having to do this like 5 times per day as the daemon(?) seems to stop running frequently for me

Didgeridoohan commented 5 years ago

@skaforey Take a look in the docs: https://topjohnwu.github.io/Magisk/tools.html

Danz17 commented 5 years ago

I report same issue, with one plus 6 pie, few apps detect root, even on hide, intune as well, installed intune hider module .. worked for solid 10 min thing again detected,

Version of magisk used is 18

sbaum commented 5 years ago

Same problem (both SafetyNet checks failing sometimes) on my Pixel 2 XL with latest Android and Magisk 18.0. Now trying if Magisk 17.3 works reliable...

dalm3000 commented 5 years ago

I have this problem too, passes after toggle. OP6T but funny thing is, when failing safetynet everything that checks for root/safetynet still works. I don't even bother toggling anymore. Google pay, PoGo, bank apps all working with safetynet failing. Odd. It does pass on boot though.

scottismyname commented 5 years ago

For me, when this problem happens, Pogo stops working, as well as Google Pay. I wrote a tasker script:

/sbin/magiskhide --disable ; sleep 2 && /sbin/magiskhide --enable

Make sure to tick the use root box. I'm not sure if the "sleep 2" is required, but without it, sometimes magiskhide would not be enabled after execution.

Then I placed a shortcut for this task on my home screen for easier execution.

JRoy commented 5 years ago

Device: Pixel 1 Android Version: 9 Security Patch: January 5th, 2019 Magisk: v18.1-1df65940

SafetyNet passes for about 10-20 minutes after a reboot, after which it fails. Toggling MagiskHide fixes this issue temporarily.

Edit: All Google apps are selected in the MagiskHide menu

AlphaDE commented 5 years ago

On OP 6, OOS 9.0.3, deleting cache/memory and removing phone permission of the Play Store doesn't help.

AlphaDE commented 5 years ago

I downgraded to Magisk 17.2 and Safetynet status check is successful again and MagiskHide works.

bettyvschmartz commented 5 years ago

This was originally raised here and a thread on XDA.

--SSS

shellster commented 5 years ago

I'm also experiencing the problem on a Nexus 6P and a Pixel 2.

EDIT: In both cases I'm experiencing a failure of SafetyNet and failure to hide, both of which occur after the phone has been running for a while and are temporarily fixed by rebooting. I've gone back to v17.3 and it also appears to have fixed the problem.

robross0606 commented 5 years ago

Same problem on Galaxy S8

asumos commented 5 years ago

Running into this issue on Pixel 3 XL Build PQ1A.181205.006 / Magisk 18

fredskis commented 5 years ago

Been having this issue on my OnePlus 6. Happens on both stable OOS 9.0.3 and the latest beta 10.

alpetrus commented 5 years ago

Moto G6 Plus (evert), LOS 16 + Havoc OS. ctsProfile and basic Integrity fails after some times of usage phone. Reboot solved the problem. Downgrade do Magisk 17.3 solve the problem permanently. Edit: the same problem on stock Pie (PPW29.116-11)

NYCJames commented 5 years ago

Also occurs on my Pixel 2

fawkes15 commented 5 years ago

Confimerd on OnePlus 5T (Android 9 OSS beta 23)

DeliriousMetro commented 5 years ago

Also present on OnePlus 6 (OOS 9.0.3, Android 9.0) and Mi 6X (MIUI 10.2, Android 8.1 - 9.1.17).

Oneplus 6 is on 1st Dec 2018 patch and Mi 6X is on 1st Jan 2019 patch level

myself379 commented 5 years ago

I'm on Xiaomi A1 Oreo 8.1 facing smiliar issue. I even tested with Magisk core only on Magisk v18

heynando commented 5 years ago

Same problem here, Motorola Z2 stock ROM, I have to reboot system to pass safety net, and sometimes toggling magisk hide doesn't work so I have to reboot again.

I've noticed this behaviour is prominent to happen after automatic updates from play store kick in whilst charging the phone. Meaning play store could be the real vilan here.

lss4 commented 5 years ago

I'm on XZ Premium with CarbonROM and having similar issues. The phone currently cannot pass ctsProfile (only basicIntegrity), but after a while (usually when the phone went to sleep for an extended amount of time), basicIntegrity won't pass anymore. And when that happens, games that detect root would refuse to start, indicating Magisk Hide has been broken.

Toggling Magisk Hide on and off could fix it for a while, but due to the amount of apps I added into the Magisk Hide, toggling it would result in restart of SystemUI as well as reinitialization of SIM card (and occasionally cellular data couldn't be brought up and I have to toggle it again).

I suspect services/threads Magisk Hide use might get killed when the phone goes to sleep for an extended amount of time so not sure if these could be made into something privileged that'll stay active, at the expense of battery life, to see if this makes a difference. If not, then the possibility that the background process management might be involved would be ruled out.

EDIT: Seems that disabling battery optimization on Magisk Manager would mitigate the issue a bit, but maybe not. I don't know if there's a way to set battery optimization at service level.

dandyrow commented 5 years ago

Issue confirmed on Galaxy S8 on oreo and several pie custom roms

Habylab commented 5 years ago

Does the latest Canary build fix this? I've seen a couple suggest so.

myzar472 commented 5 years ago

tried a few weeks ago on a pixel 3... same issue

Pitel commented 5 years ago

Same issue. Nexus 5X, LineageOS 15.1 (some fo the laatest builds).

ctsProfile is false, basicIntegrity is true. Disabling MagiskHide makes boths false.

Pokemon Go works, but can't pay with Google Pay.

EDIT: Same with 18.1 canary.

Habylab commented 5 years ago

Confirming first and latest 18.1 Canary doesn't fix the issue. It's been acknowledged in stable release notes though.

xksefa commented 5 years ago

Confirming it is not solved on 18.1 but I couldn't see any statement saying it is solved in release notes.

Didgeridoohan commented 5 years ago

Same issue. Nexus 5X, LineageOS 15.1 (some fo the laatest builds).

ctsProfile is false, basicIntegrity is true. Disabling MagiskHide makes boths false.

Pokemon Go works, but can't pay with Google Pay.

EDIT: Same with 18.1 canary.

No, you do not have the same issue. That you have basicIntegrity reporting as true means that MagiskHide is working on your device, but that LineageOS doesn't use a certified device fingerprint (which I believe the official builds never will). There are modules available in the Magisk repo that can help with that...

diemadedrei commented 5 years ago

Same problem here on oneplus 6, lineageOS 16 but only since 18.1 it was working with 18. It seems to stop working the moment my payment app checks safetynet.

amanteae commented 5 years ago

anyone using magisk with adguard? I found adguard might break magisk hide, but thy fixed in the yesterday nightly build.

image

xksefa commented 5 years ago

I was using with AdAway not Adguard. But still the same issue.

James-Oakley commented 5 years ago

Is that Adguard issue related to this issue with Magisk?

amanteae commented 5 years ago

I still believe it's Magisk issue. i still have safetynet failure after upgrading to the adguard nightly build. I'm using magisk canary build btw.

AlphaDE commented 5 years ago

I find it strange that new versions are released and the author is not even reacting to this major issue, making Magisk 18.x useless fir me and many others..

And it's more than the title states, on my device, MagiskHide isn't working at all.

shellster commented 5 years ago

An update. I've been back on 17.3 for about a month now, and it has been rock solid. Zero root detections. As far as I'm concerned, there is definitely a bug that was introduced in v18+ releases.

papjul commented 5 years ago

Hi @topjohnwu Could you update us on your findings? I was thinking that this might be due to a change in target API. I know that latest API have different battery saving options, which may result in a more aggressive background killing of process/services, such as MagiskHide.

amanteae commented 5 years ago

An update. I've been back on 17.3 for about a month now, and it has been rock solid. Zero root detections. As far as I'm concerned, there is definitely a bug that was introduced in v18+ releases.

Magisk hide is ok on 17.3, but repacking the magisk manager is not ok. I haven't tried magisk manager v7 + magisk v17.3 yet.

papjul commented 5 years ago

An update. I've been back on 17.3 for about a month now, and it has been rock solid. Zero root detections. As far as I'm concerned, there is definitely a bug that was introduced in v18+ releases.

Magisk hide is ok on 17.3, but repacking the magisk manager is not ok. I haven't tried magisk manager v7 + magisk v17.3 yet.

You can't. Magisk Manager V7 dropped support for Magisk < 18.0: https://github.com/topjohnwu/Magisk/blob/v18.1/app/src/full/res/raw/changelog.md