search

topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
47.59k stars 12.08k forks source link

documents.ui (stock file manager) debug info breaks after magisk installation #982

Closed vvkjndl closed 5 years ago

vvkjndl commented 5 years ago

once magisk is installed stock file manager (com.android.documentsui) will no longer show debug info.

tested plaform: android pie, havoc os, magisk 18.0

tried magisk hide on app.

let me know if you need any additional info or logs.

topjohnwu commented 5 years ago

This is 99% caused by the fact that MagiskHide will force revert ro.build.type from userdebug to user. Nothing to fix here.

Didgeridoohan commented 5 years ago

@vivekjindal You can test by disabling MagiskHide and if it starts workning after that you can use the MagiskHide Props Config module (it's in the Manager Downloads) to revert that particular prop even with MagiskHide enabled.

vvkjndl commented 5 years ago

Changing the ro.build.type value from user to userdebug didn't resolve the issue. However, disabling the MagiskHide feature solves the issue. Any other way to solve this while keeping MagiskHide enabled?

Didgeridoohan commented 5 years ago

Try reverting the other MagiskHide props as well, one by one until you find the culprit (if it's caused by one of those)...

vvkjndl commented 5 years ago

tried all possible settings in props. it didn't work. debug info is displayed only when MagiskHide is enabled. Can you tell which prop files MagiskHide functionality is touching? I was studying MagiskHide activity but given my limited knowledge of programming I couldn't figure it out.