topjung3 / npr-android-app

Automatically exported from code.google.com/p/npr-android-app
0 stars 0 forks source link

Number of items in Top Stories list is incorrect #92

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Start app and view the Top Stories screen
2. Scroll story list
3. Notice it only shows 5 stories before the 'Load more stories...' row

What is the expected output? What do you see instead?
I expected to see at least 10 stories consistent with the number of items in 
the lists when you view a topic like News, U.S., Business, etc.. 

Top Stories only shows 5. 

What version of the product are you using? On what operating system?
Version name: 1.8.126
Version code: 3

Phone: Moto Droid 1 - Android 2.3.4 w/ Custom ROM

Please provide any additional information below.
I took a peek at the code and the number of items for Top Stories is explicitly 
being set to 5, so I'm not actually sure if this behavior is by design or a bug.

Original issue reported on code.google.com by donnie.m...@gmail.com on 16 Jun 2011 at 6:27

GoogleCodeExporter commented 9 years ago
5 was chosen for the top stories because it's the first to load and we wanted 
to block as little as possible. That said five is too few. A quick solution as 
suggested previously on the list is to kick off another five immediately after 
the first returns so that it's responsive and loads more.

A bigger effort is to support progressive loading like Gmail where stories are 
loaded as you scroll closer to the end. This would apply to swiping through 
stories in the NewsStoryActivity as well.

Original comment by jeremy.w...@gmail.com on 16 Jun 2011 at 3:03

GoogleCodeExporter commented 9 years ago

Original comment by jeremy.w...@gmail.com on 16 Jun 2011 at 3:03

GoogleCodeExporter commented 9 years ago
This will most likely be wrapped up by some design tweaks to the story list 
view for 2.1. Might slip to later thou.

Original comment by jpenn...@gmail.com on 17 Jun 2011 at 7:24

GoogleCodeExporter commented 9 years ago

Original comment by jpenn...@gmail.com on 10 Jan 2012 at 7:22