search

topkecleon / telegram-bot-bash

Telegram bot written in bash
Other
431 stars 123 forks source link

New bug sending files #111

Closed amontigita closed 4 years ago

amontigita commented 4 years ago

Since a few days ago, I was not able to get files like pics. I discovered that this line in bashbot.sh was blocking it: echo "$file" | grep -qE $FILE_REGEX || return to be changed in the following: echo "$file" | grep -qE "$FILE_REGEX" || return

I do not why it stopped working, I did not made any change to "commands.sh", but it did.

gnadelwartz commented 4 years ago

Thanks for reporting, this is indeed a bug. If its also in the latest version I'll fix it

Am 26. November 2019 17:29:03 schrieb amontigita notifications@github.com:

Since a few days ago, I was not able to get files like pics. I discovered that this line in bashbot.sh was blocking it: echo "$file" | grep -qE $FILE_REGEX || return to be changed in the following: echo "$file" | grep -qE "$FILE_REGEX" || return

I do not why it stopped working, I did not made any change to "commands.sh", but it did.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

amontigita commented 4 years ago

Well, good then. I love that software. It handles my home automation, with my raspi. It worked for months flawlessly-

Andrea Monti-Guarnieri

On Tue, Nov 26, 2019 at 5:54 PM Kay Marquardt notifications@github.com<mailto:notifications@github.com> wrote: Thanks for reporting, this is indeed a bug. If its also in the latest version I'll fix it

Am 26. November 2019 17:29:03 schrieb amontigita notifications@github.com<mailto:notifications@github.com>:

Since a few days ago, I was not able to get files like pics. I discovered that this line in bashbot.sh was blocking it: echo "$file" | grep -qE $FILE_REGEX || return to be changed in the following: echo "$file" | grep -qE "$FILE_REGEX" || return

I do not why it stopped working, I did not made any change to "commands.sh", but it did.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/topkecleon/telegram-bot-bash/issues/111?email_source=notifications&email_token=ALUCR6MSMGAACIQ7Z6J4ZE3QVVIFTA5CNFSM4JR2TO62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFGWVCA#issuecomment-558721672, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALUCR6K7I4VM2TBD3QGP54TQVVIFTANCNFSM4JR2TO6Q.

gnadelwartz commented 4 years ago

it's indeed also in the newest Version, I'll fix it with the nex release.

BTW: as you find the line in bashbot.sh, it seems you are using an older version of bashbot. you may consider upgrading because of many enhancements and security fixes

the bug you found is in modules/sendmessage in the current version.

https://github.com/topkecleon/telegram-bot-bash/commit/91ad865c17095017f81146509d9221d756c76d83

gnadelwartz commented 4 years ago

HI, I have to revert the change because with quotes the regex is compared as string, not regex.

remember if you want to allow only files from e.g. "/home/user/test/" the regex should be "^/home/user/test/."