topmonks / heureka-extension

Ověřte si běžnou cenu produktu bez nutnosti opouštět prohlížený e-shop
https://chrome.google.com/webstore/detail/jmhkgcmmgjblnkjkbgjggkaeifacakgi
18 stars 6 forks source link

Fix: do not run product info parsing logic on non product pages #10

Closed Strajk closed 4 years ago

Strajk commented 4 years ago

Due to current architecture based on object getters and destructuring, product page logic is executed also on non-product pages... e.g. productPrice is called on e-shop home page.

Current 🤔

2020-03-24 07 50 01

Proposed 🥳

2020-03-24 07 55 23


I'm working on more support for more shops, and in some, the logic for getting the price is a little bit more complicated and it should be run only if needed.

Strajk commented 4 years ago

btw if you don't have the release to chrome store automated (yet), do not feel obliged to do it after every single PR – I plan to add support for every shop in separate PR :)

junkycoder commented 4 years ago

@Strajk thaaanks man, nice optimisation catch 👍

Ping me whenever you will be ready to release