search

topo-io / tiptap-extensions

Column extension for tiptap v2
https://codesandbox.io/p/github/GoCapsule/tiptap-extensions/main
85 stars 15 forks source link

language agnostic implementation #9

Closed marclave closed 1 year ago

marclave commented 1 year ago

Hey!

Love this package, I wasn't too familiar with React so I made an implementation of it in pure typescript so react or vue can use it!

https://github.com/marclave/extension-columns

Should I make a pr that follows this repo?

leonard-henriquez commented 1 year ago

Hi @marclave ! If you open a PR I would be happy to review and merge it ! Sounds like a good idea to make this project language agnostic

marclave commented 1 year ago

@leonard-henriquez cool, i'll do that later today! 😸

marclave commented 1 year ago

@leonard-henriquez sorry seemed like a weekend task!

I have the pull request ready but I couldn't push to the repo or make new branches.

Should I fork it?

leonard-henriquez commented 1 year ago

Thank you Marc ! You can fork it and make a PR from your repo to this repo 🙂 I'll be happy to review it !

marclave commented 1 year ago

https://github.com/GoCapsule/tiptap-extensions/pull/10

done!

marclave commented 1 year ago

Closed in #10

leonard-henriquez commented 1 year ago

It has been released in v1.0.0-beta-3