topocm / topocm_content

Course on topology in condensed matter
http://topocondmat.org
Other
279 stars 144 forks source link

Week11 #162

Closed basnijholt closed 8 years ago

akhmerov commented 8 years ago

We still need to fix the crystalline TI.

akhmerov commented 8 years ago

In cti.ipynb both nanowire_chains and stacked_qwz are used exactly once. I think this would make it better to move the functions exactly to the cells where they are used; what do you say?

basnijholt commented 8 years ago

I agree.

On Apr 19, 2016, 11:53 +0200, Anton Akhmerovnotifications@github.com, wrote:

Incti.ipynbbothnanowire_chainsandstacked_qwzare used exactly once. I think this would make it better to move the functions exactly to the cells where they are used; what do you say?

— You are receiving this because you authored the thread. Reply to this email directly orview it on GitHub(https://github.com/topocm/topocm_content/pull/162#issuecomment-211831213)

akhmerov commented 8 years ago

Same thing holds for nanowire_chain inside floquet.ipynb. Finally I suggest to rename get_evolution_operator into evolution_operator and add a docstring that explicitly says that each Hamiltonian is applied for the same fraction of a period.

The text changes look quite good!

basnijholt commented 8 years ago

Both fixed.

akhmerov commented 8 years ago

Thanks!