topolik
commented
9 years ago HI @izaera
Looks promising, thanks!
Open izaera opened 9 years ago
topolik
commented
9 years ago HI @izaera
Looks promising, thanks!
izaera
commented
9 years ago If you finally decide to apply it, ask me and I will give you a brief introduction on how it is supposed to work. Basically what I did is separating the portal stuff from the external repository stuff, so that you only have to deal with the external repository and not with Liferay portal.
For example, when using dl-repository-shared you don't need to work with Liferay ids, only with the ones from your external repo. You don't even need to manipulate the RepositoryEntry table because it is not referenced anywhere in the interfaces you need to implement. You just provide an implementation for the file, folder and version object, and another one with the operations the repository support and that's all.
topolik
commented
9 years ago +100
This looks very very good. I had to implement that myself, all the mapping.
Btw. does it support DL permissions? Once the IDs are on the framework side the implementation cannot work with resource permissions.
izaera
commented
9 years ago I'm not sure of what you mean. There's a place where you have to map "Liferay permissions" to "your repo permissions". See this file:
method containsPermission() receives an ExtRepositoryPermission, which is an enum defined at the end of that class. Those are based on Liferay's ones, but it's only a subset of what is needed. For example I removed CREATE_SHORTCUT because there's no support for shortcuts in external repos.
On 2/2/15 11:42, Tomáš Polešovský wrote:
+100
This looks very very good. I had to implement that myself, all the mapping.
Btw. does it support DL permissions? Once the IDs are on the framework side the implementation cannot work with resource permissions.
— Reply to this email directly or view it on GitHub https://github.com/topolik/FSRepo/issues/15#issuecomment-72436815.
topolik
commented
9 years ago I mean - portal admin creates custom role that is able to create DL folders. Does it check that permission and make sure it cannot reach my code when user doesn't have the permission?
-- tom +
On Mon, Feb 2, 2015 at 11:47 AM, Ivan Zaera notifications@github.com wrote:
I'm not sure of what you mean. There's a place where you have to map "Liferay permissions" to "your repo permissions". See this file:
method containsPermission() receives an ExtRepositoryPermission, which is an enum defined at the end of that class. Those are based on Liferay's ones, but it's only a subset of what is needed. For example I removed CREATE_SHORTCUT because there's no support for shortcuts in external repos.
On 2/2/15 11:42, Tomáš Polešovský wrote:
+100
This looks very very good. I had to implement that myself, all the mapping.
Btw. does it support DL permissions? Once the IDs are on the framework side the implementation cannot work with resource permissions.
— Reply to this email directly or view it on GitHub https://github.com/topolik/FSRepo/issues/15#issuecomment-72436815.
— Reply to this email directly or view it on GitHub https://github.com/topolik/FSRepo/issues/15#issuecomment-72437442.
izaera
commented
9 years ago No idea :-(. I would have to check it in the code. I suppose the answer is yes, but I cannot give you the answer off the top of my head.
On 2/2/15 11:52, Tomáš Polešovský wrote:
I mean - portal admin creates custom role that is able to create DL folders. Does it check that permission and make sure it cannot reach my code when user doesn't have the permission?
-- tom +
On Mon, Feb 2, 2015 at 11:47 AM, Ivan Zaera notifications@github.com wrote:
I'm not sure of what you mean. There's a place where you have to map "Liferay permissions" to "your repo permissions". See this file:
method containsPermission() receives an ExtRepositoryPermission, which is an enum defined at the end of that class. Those are based on Liferay's ones, but it's only a subset of what is needed. For example I removed CREATE_SHORTCUT because there's no support for shortcuts in external repos.
On 2/2/15 11:42, Tomáš Polešovský wrote:
+100
This looks very very good. I had to implement that myself, all the mapping.
Btw. does it support DL permissions? Once the IDs are on the framework side the implementation cannot work with resource permissions.
— Reply to this email directly or view it on GitHub https://github.com/topolik/FSRepo/issues/15#issuecomment-72436815.
— Reply to this email directly or view it on GitHub https://github.com/topolik/FSRepo/issues/15#issuecomment-72437442.
— Reply to this email directly or view it on GitHub https://github.com/topolik/FSRepo/issues/15#issuecomment-72438219.
Hi @topolik:
I didn't know you had created this connector. Looks good and it's a great idea.
I was wondering if you could be interested in looking at dl-repository-shared layer, which is a JAR file I wrote to make implementation of connectors much easier and maintainablec.
It's in here: https://github.com/liferay/liferay-plugins/tree/master/shared/dl-repository-shared You can see how it is used in Documentum and Sharepoint connectors in liferay-plugins-ee.
If some day you consider to migrate to this new layer don't hesitate to ask me for any advice.
Cheers, Ivan