Closed sfroment closed 1 month ago
@JanLewDev adapted, shall I had a function to get the store name so we don't do a mistake when wanting to use this store name ?
@JanLewDev adapted, shall I had a function to get the store name so we don't do a mistake when wanting to use this store name ?
sure, will make it cleaner
helper function added hopefully where you were wanting it, otherwise in the keeper.go
, nonetheless this function is more a util one ?
After this lgtm
Hey 👋 ,
This PR aim to fix #8. I wasn't sure wherever or not a subscription could be set twice this is why I go with a map to be sure all subscription are unique. If this isn't the case we could go with a slice and it will make the subscription retrieval even easier. Also would you like the
SetSubscription
to be divided like so:Or like so:
Let me know thanks.