This PR fixes the vtuToDiagram function when TTK is compiled with 64 bit ids.
In the diagramToVTU function, the arrays ttk::PersistencePairIdentifierName and ttk::VertexScalarFieldName are of types ttkSimplexIdTypeArray (that is either vtkIntArray or vtkIdTypeArray if 64 bit ids is respectively disabled or not).
However, currently, the corresponding arrays in the vtuToDiagram function are only read with a SafeDownCast to vtkIntArray returning therefore a nullptr when TTK is compiled with 64 bit ids.
It can leads to problems in other methods using persistence diagrams, for instance executing states/persistenceDiagramClustering.pvsm does not work with 64 bit ids and the current TTK (except if I have missed something).
julien-tierny
commented
4 months ago
This PR fixes the
vtuToDiagramfunction when TTK is compiled with 64 bit ids.In the
diagramToVTUfunction, the arraysttk::PersistencePairIdentifierNameandttk::VertexScalarFieldNameare of typesttkSimplexIdTypeArray(that is eithervtkIntArrayorvtkIdTypeArrayif 64 bit ids is respectively disabled or not). However, currently, the corresponding arrays in thevtuToDiagramfunction are only read with aSafeDownCasttovtkIntArrayreturning therefore anullptrwhen TTK is compiled with 64 bit ids.It can leads to problems in other methods using persistence diagrams, for instance executing
states/persistenceDiagramClustering.pvsmdoes not work with 64 bit ids and the current TTK (except if I have missed something).