julien-tierny
commented
2 months ago Wonderful, thanks a lot Florian! Could you please:
- fix the issues raised by the continuous integration? (warnings)
- submit a PR to ttk-data with new examples using the path mapping distance capabilities, for instance by adapting the examples covered by the Wasserstein distance (https://topology-tool-kit.github.io/examples/mergeTreeClustering/, https://topology-tool-kit.github.io/examples/mergeTreeFeatureTracking/, https://topology-tool-kit.github.io/examples/mergeTreeTemporalReduction/). This aspect is important, to make sure we can test your contribution in the future and make sure there's no regression. Thanks!
floWetzels
This PR adds the path mapping distance to the MergeTreeBarycenter, MergeTreeClustering and MergeTreeTemporalReduction modules. Furthermore, the PlanarGraphLayout has been adapted to also enable a "path based layout" for merge trees. It also contains some bug fixes, additions and minor refactorings for other modules related to merge tree edit distances, e.g. when using BDIEDs in MergeTreeDistanceMatrix, it is now possible to apply the preprocessing steps also available for other distances.
In essence, this PR adds the code for the VIS23 paper "Merge Tree Geodesics and Barycenters with Path Mappings" and further related adaptations.
Some further changes are still pending and will be added by @MatPont soon. So please don't merge until they are finished.
An accompanying ttk-data PR will come soon, too.