search

topology-tool-kit / ttk

TTK - Topological Data Analysis and Visualization - Source Code
https://topology-tool-kit.github.io/
Other
406 stars 120 forks source link

Topomap missing boost dependency #1033

Closed petersteneteg closed 1 month ago

petersteneteg commented 1 month ago

Describe the bug

When Qhull is not found or if TTK_ENABLE_QHULL is false the TopoMap module will use boost, but the CMakeList file does not link boost.

Adding this at the end will fix the issue

if(NOT TTK_ENABLE_QHULL OR NOT Qhull_FOUND)
  target_link_libraries(topoMap PUBLIC Boost::boost)
endif()
julien-tierny commented 1 month ago

Thanks a lot for the heads up. TopoMap built fine under linux without this patch and our windows CI didn't catch up the issue (as it installed QHull). The PR #1034 should address that. Thanks for letting me know if #1034 is OK for you. Best,

petersteneteg commented 1 month ago

Great! that's perfect. Thank you!

julien-tierny commented 1 month ago

thanks a lot for the hot fix!