topology-tool-kit / ttk

TTK - Topological Data Analysis and Visualization - Source Code
https://topology-tool-kit.github.io/
Other
418 stars 124 forks source link

Can 64-bit option rely on VTK for consistency? #729

Open jspanchu opened 2 years ago

jspanchu commented 2 years ago

Is your feature request related to a problem? Please describe. It is strange when we intermix code that uses vtk filters and ttk filters. Some assumptions on the 'id' data type can no longer be safe. (int vs long long, ttk::SimplexId vs vtkIdType)

Describe the solution you'd like It would be nice if ttk::SimplexId and vtkIdType were consistent when TTK is built with ParaView/VTK support. The cmake config script can check to see if VTK was built with support for 64-bit id type. If it were the case, then we turn on TTK_ENABLE_64_BIT_IDS. By default, this option is turned off config.cmake:98

JonasLukasczyk commented 2 years ago

This seems reasonable to me. +1

julien-tierny commented 2 years ago

in principle, that makes sense. two things:

jspanchu commented 2 years ago

Fair enough. Let me know if there is anything I can do to help!