search

topology-tool-kit / ttk

TTK - Topological Data Analysis and Visualization - Source Code
https://topology-tool-kit.github.io/
Other
406 stars 120 forks source link

Fix compiler warnings and 1 UB instances #996

Closed duncanspumpkin closed 7 months ago

duncanspumpkin commented 7 months ago

This fixes a few little warnings and errors that i've noticed from using ttk. There are related issues for each of the commits detailing what the problem is refer to the issues for more information.

julien-tierny commented 7 months ago

hi @duncanspumpkin , thanks a lot for the PR! could you please run clang-format on your PR? (see https://github.com/topology-tool-kit/ttk/blob/dev/CONTRIBUTING.md#2-code-formatting) Thanks!

duncanspumpkin commented 7 months ago

hi @duncanspumpkin , thanks a lot for the PR! could you please run clang-format on your PR? (see https://github.com/topology-tool-kit/ttk/blob/dev/CONTRIBUTING.md#2-code-formatting) Thanks!

Sure, done. It would be useful if the ci outputed the patches that it is expecting. Took me a little while to work out what it was saying was wrong. Then contributors don't need to have the same version of clang format installed (I normally only have clang format installed as part of MSVC which at present is 17.0.2)

julien-tierny commented 7 months ago

thanks a lot duncan!