search

topolvm / pvc-autoresizer

Auto-resize PersistentVolumeClaim objects based on Prometheus metrics
Apache License 2.0
249 stars 29 forks source link

adding annotations to the deployment #279

Closed ekirmayer closed 2 months ago

ekirmayer commented 2 months ago

This will allow passing annotations at the deployment level. Allow supporting controllers which use the deployment annotations.

ushitora-anqou commented 2 months ago

@ekirmayer Could you update your code so that the CI can pass? It looks like you need to run make generate once. Thanks!

ekirmayer commented 2 months ago

@ushitora-anqou i see that there are two failing test on connectivity but i cant re-trigger the action. Is it something i need to fix?

ushitora-anqou commented 2 months ago

I don't think you need to fix anything. Actually, the e2e tests are kind of flaky. I'll retry them.

toshipp commented 2 months ago

This flakiness is consistently happened on CI. I'll try to solve it.

toshipp commented 2 months ago

@ekirmayer Hi, I fixed the flakiness, could you rebase on the main branch?

toshipp commented 2 months ago

Still failing... I'll dig into it more.

toshipp commented 2 months ago

I retried and CI passed. I suspect the flakiness may still exist, but we can proceed.

ushitora-anqou commented 2 months ago

Thank you for your contribution!