search

toposware / frost

A fork of frost-dalek, made WASM compatible, and upgraded to Static ICE-FROST
BSD 3-Clause "New" or "Revised" License
14 stars 2 forks source link

Use Rust formatting #41

Closed Nashtare closed 2 years ago

Nashtare commented 2 years ago

Given the increasing differences there are with the original repository (+ it seems it has been abandoned?), we may want to apply rustfmt to be consistent with the rest of our codebase, and insert back the rule in the CI jobs.

Nashtare commented 2 years ago

Any thoughts on this @hadjiszs @Freyskeyd? The upstream repo is clearly abandoned, we've made two major updates to the original FROST construction, bringing us quite away from it, and some portions of the codebase really hurt my eyes..

Freyskeyd commented 2 years ago

I'm OK to apply a Rustfmt if the upstream repository is abandoned. And yes, if we clean up the code style, we need to enforce these rules by using fmt Github actions.