search

topoteretes / cognee

Reliable LLM Memory for AI Applications and AI Agents
https://www.cognee.ai
Apache License 2.0
822 stars 57 forks source link

chore: remove unnecessary env variables #136

Closed borisarzentar closed 3 weeks ago

borisarzentar commented 3 weeks ago

Summary by CodeRabbit

gitguardian[bot] commented 3 weeks ago

⚠️ GitGuardian has uncovered 25 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165459966) | Triggered | Generic Password | 6ca21543794149a2f2719853d79e64ffd669f3e0 | .github/workflows/test_neo4j.yml | [View secret](https://github.com/topoteretes/cognee/commit/6ca21543794149a2f2719853d79e64ffd669f3e0#diff-7cae904a66e83e6b2cdcb4b3b53611566e3300ff502496f2dbc7f4a5874e96c9R89) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165459967) | Triggered | Generic Password | 6ca21543794149a2f2719853d79e64ffd669f3e0 | .github/workflows/test_python_3_9.yml | [View secret](https://github.com/topoteretes/cognee/commit/6ca21543794149a2f2719853d79e64ffd669f3e0#diff-41001bb5a6cf19d877e7bd248ceaa6ffcae0f8375ecf790bf539c496dda6ac7dL102) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165459968) | Triggered | Generic Password | 6ca21543794149a2f2719853d79e64ffd669f3e0 | .github/workflows/test_weaviate.yml | [View secret](https://github.com/topoteretes/cognee/commit/6ca21543794149a2f2719853d79e64ffd669f3e0#diff-07f6b21321dafb13938fc4e7b5944f474983bee1dfcd769bb0c1b28a0edd5a31L89) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165459969) | Triggered | Generic Password | 6ca21543794149a2f2719853d79e64ffd669f3e0 | .github/workflows/test_neo4j.yml | [View secret](https://github.com/topoteretes/cognee/commit/6ca21543794149a2f2719853d79e64ffd669f3e0#diff-7cae904a66e83e6b2cdcb4b3b53611566e3300ff502496f2dbc7f4a5874e96c9L96) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165459970) | Triggered | Generic Password | 6ca21543794149a2f2719853d79e64ffd669f3e0 | .github/workflows/test_python_3_11.yml | [View secret](https://github.com/topoteretes/cognee/commit/6ca21543794149a2f2719853d79e64ffd669f3e0#diff-4539568adca7c3c8842838f162bd339b5f7f1febb7943298ac52611dfd7dfe9eR100) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165459971) | Triggered | Generic Password | 6ca21543794149a2f2719853d79e64ffd669f3e0 | .github/workflows/test_neo4j.yml | [View secret](https://github.com/topoteretes/cognee/commit/6ca21543794149a2f2719853d79e64ffd669f3e0#diff-7cae904a66e83e6b2cdcb4b3b53611566e3300ff502496f2dbc7f4a5874e96c9L90) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165459972) | Triggered | Generic Password | 6ca21543794149a2f2719853d79e64ffd669f3e0 | .github/workflows/test_python_3_9.yml | [View secret](https://github.com/topoteretes/cognee/commit/6ca21543794149a2f2719853d79e64ffd669f3e0#diff-41001bb5a6cf19d877e7bd248ceaa6ffcae0f8375ecf790bf539c496dda6ac7dR100) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165459973) | Triggered | Generic Password | 6ca21543794149a2f2719853d79e64ffd669f3e0 | .github/workflows/test_weaviate.yml | [View secret](https://github.com/topoteretes/cognee/commit/6ca21543794149a2f2719853d79e64ffd669f3e0#diff-07f6b21321dafb13938fc4e7b5944f474983bee1dfcd769bb0c1b28a0edd5a31R88) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165459974) | Triggered | Generic Password | 6ca21543794149a2f2719853d79e64ffd669f3e0 | .github/workflows/test_qdrant.yml | [View secret](https://github.com/topoteretes/cognee/commit/6ca21543794149a2f2719853d79e64ffd669f3e0#diff-3f9a7290d0baa5bfb33332fad38b076f261a255557b601b8271cf738e5ac96a8L89) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165459975) | Triggered | Generic Password | 6ca21543794149a2f2719853d79e64ffd669f3e0 | .github/workflows/test_qdrant.yml | [View secret](https://github.com/topoteretes/cognee/commit/6ca21543794149a2f2719853d79e64ffd669f3e0#diff-3f9a7290d0baa5bfb33332fad38b076f261a255557b601b8271cf738e5ac96a8L95) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165459976) | Triggered | Generic Password | 6ca21543794149a2f2719853d79e64ffd669f3e0 | .github/workflows/test_weaviate.yml | [View secret](https://github.com/topoteretes/cognee/commit/6ca21543794149a2f2719853d79e64ffd669f3e0#diff-07f6b21321dafb13938fc4e7b5944f474983bee1dfcd769bb0c1b28a0edd5a31L95) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165459977) | Triggered | Generic Password | 6ca21543794149a2f2719853d79e64ffd669f3e0 | .env.template | [View secret](https://github.com/topoteretes/cognee/commit/6ca21543794149a2f2719853d79e64ffd669f3e0#diff-749e06f64632f62a0c0dfbf4c4f3850e27e94ac109aa121fabd5c29469ae88deR24) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165459978) | Triggered | Generic Password | 6ca21543794149a2f2719853d79e64ffd669f3e0 | .github/workflows/test_python_3_10.yml | [View secret](https://github.com/topoteretes/cognee/commit/6ca21543794149a2f2719853d79e64ffd669f3e0#diff-60a78f6db53f6f4d2dbc8fc39943e90f442aaeb1b60ae3b6cb645460f3c51d0dR100) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165459979) | Triggered | Generic Password | 6ca21543794149a2f2719853d79e64ffd669f3e0 | .github/workflows/test_python_3_10.yml | [View secret](https://github.com/topoteretes/cognee/commit/6ca21543794149a2f2719853d79e64ffd669f3e0#diff-60a78f6db53f6f4d2dbc8fc39943e90f442aaeb1b60ae3b6cb645460f3c51d0dL102) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165459980) | Triggered | Generic Password | 6ca21543794149a2f2719853d79e64ffd669f3e0 | .github/workflows/test_qdrant.yml | [View secret](https://github.com/topoteretes/cognee/commit/6ca21543794149a2f2719853d79e64ffd669f3e0#diff-3f9a7290d0baa5bfb33332fad38b076f261a255557b601b8271cf738e5ac96a8R88) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165459981) | Triggered | Generic Password | 6ca21543794149a2f2719853d79e64ffd669f3e0 | .github/workflows/test_python_3_11.yml | [View secret](https://github.com/topoteretes/cognee/commit/6ca21543794149a2f2719853d79e64ffd669f3e0#diff-4539568adca7c3c8842838f162bd339b5f7f1febb7943298ac52611dfd7dfe9eL102) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165460168) | Triggered | Generic Password | a487a5f9ed8cbb6821abec16f73eaca3223c1122 | .github/workflows/test_python_3_11.yml | [View secret](https://github.com/topoteretes/cognee/commit/a487a5f9ed8cbb6821abec16f73eaca3223c1122#diff-4539568adca7c3c8842838f162bd339b5f7f1febb7943298ac52611dfd7dfe9eR106) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165460169) | Triggered | Generic Password | a487a5f9ed8cbb6821abec16f73eaca3223c1122 | .github/workflows/test_python_3_9.yml | [View secret](https://github.com/topoteretes/cognee/commit/a487a5f9ed8cbb6821abec16f73eaca3223c1122#diff-41001bb5a6cf19d877e7bd248ceaa6ffcae0f8375ecf790bf539c496dda6ac7dR106) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165460170) | Triggered | Generic Password | a487a5f9ed8cbb6821abec16f73eaca3223c1122 | .github/workflows/test_python_3_10.yml | [View secret](https://github.com/topoteretes/cognee/commit/a487a5f9ed8cbb6821abec16f73eaca3223c1122#diff-60a78f6db53f6f4d2dbc8fc39943e90f442aaeb1b60ae3b6cb645460f3c51d0dL100) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165460171) | Triggered | Generic Password | a487a5f9ed8cbb6821abec16f73eaca3223c1122 | .github/workflows/test_python_3_10.yml | [View secret](https://github.com/topoteretes/cognee/commit/a487a5f9ed8cbb6821abec16f73eaca3223c1122#diff-60a78f6db53f6f4d2dbc8fc39943e90f442aaeb1b60ae3b6cb645460f3c51d0dR106) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165460172) | Triggered | Generic Password | a487a5f9ed8cbb6821abec16f73eaca3223c1122 | .github/workflows/test_neo4j.yml | [View secret](https://github.com/topoteretes/cognee/commit/a487a5f9ed8cbb6821abec16f73eaca3223c1122#diff-7cae904a66e83e6b2cdcb4b3b53611566e3300ff502496f2dbc7f4a5874e96c9R96) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165460173) | Triggered | Generic Password | a487a5f9ed8cbb6821abec16f73eaca3223c1122 | .github/workflows/test_python_3_9.yml | [View secret](https://github.com/topoteretes/cognee/commit/a487a5f9ed8cbb6821abec16f73eaca3223c1122#diff-41001bb5a6cf19d877e7bd248ceaa6ffcae0f8375ecf790bf539c496dda6ac7dL100) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165460174) | Triggered | Generic Password | a487a5f9ed8cbb6821abec16f73eaca3223c1122 | .github/workflows/test_python_3_11.yml | [View secret](https://github.com/topoteretes/cognee/commit/a487a5f9ed8cbb6821abec16f73eaca3223c1122#diff-4539568adca7c3c8842838f162bd339b5f7f1febb7943298ac52611dfd7dfe9eL100) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165460175) | Triggered | Generic Password | a487a5f9ed8cbb6821abec16f73eaca3223c1122 | .github/workflows/test_weaviate.yml | [View secret](https://github.com/topoteretes/cognee/commit/a487a5f9ed8cbb6821abec16f73eaca3223c1122#diff-07f6b21321dafb13938fc4e7b5944f474983bee1dfcd769bb0c1b28a0edd5a31R95) | | [9573981](https://dashboard.gitguardian.com/workspace/419078/incidents/9573981?occurrence=165460176) | Triggered | Generic Password | a487a5f9ed8cbb6821abec16f73eaca3223c1122 | .github/workflows/test_qdrant.yml | [View secret](https://github.com/topoteretes/cognee/commit/a487a5f9ed8cbb6821abec16f73eaca3223c1122#diff-3f9a7290d0baa5bfb33332fad38b076f261a255557b601b8271cf738e5ac96a8R95) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

coderabbitai[bot] commented 3 weeks ago

Walkthrough

The changes involve a comprehensive restructuring of environment variable definitions across multiple configuration files, emphasizing a more streamlined approach for local development. New variables related to machine learning, error reporting, and database configurations have been introduced, while existing variables have been renamed or removed for clarity and consistency. Additionally, AWS credentials have been removed from the base configuration, indicating a shift in how the application interacts with AWS resources.

Changes

Files Change Summary
.env.template Restructured environment variables for local development, added new variables for ML and databases.
.github/workflows/test_neo4j.yml Renamed PostgreSQL-related environment variables to a more generic format.
.github/workflows/test_python_3_10.yml Simplified database credential variable names; removed OPENAI_API_KEY.
.github/workflows/test_python_3_11.yml Streamlined environment variable names for database credentials; retained LLM_API_KEY.
.github/workflows/test_python_3_9.yml Updated database credential variable names for clarity; retained OPENAI_API_KEY.
.github/workflows/test_qdrant.yml Replaced PostgreSQL credentials with simplified naming; removed redundant variables.
.github/workflows/test_weaviate.yml Renamed PostgreSQL variables to DB_* format for consistency; retained OPENAI_API_KEY.
cognee/base_config.py Removed aws_access_key_id and aws_secret_access_key attributes from BaseConfig.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant LocalEnv
    participant Database
    participant MLService
    participant ErrorReporting

    Developer->>LocalEnv: Set up environment variables
    LocalEnv->>Database: Connect using DB_* variables
    LocalEnv->>MLService: Authenticate using LLM_API_KEY
    LocalEnv->>ErrorReporting: Send reports to SENTRY_REPORTING_URL

Poem

🐰 In a world of code, so bright and new,
Variables dance, like morning dew.
With names so clear, they hop and play,
Streamlined for joy, in a bright array.
No more AWS keys in sight,
Just local dreams, taking flight! 🌟

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 6ca21543794149a2f2719853d79e64ffd669f3e0 and a487a5f9ed8cbb6821abec16f73eaca3223c1122.
Files selected for processing (6) * .github/workflows/test_neo4j.yml (1 hunks) * .github/workflows/test_python_3_10.yml (1 hunks) * .github/workflows/test_python_3_11.yml (1 hunks) * .github/workflows/test_python_3_9.yml (1 hunks) * .github/workflows/test_qdrant.yml (1 hunks) * .github/workflows/test_weaviate.yml (1 hunks)
Files skipped from review due to trivial changes (1) * .github/workflows/test_weaviate.yml
Files skipped from review as they are similar to previous changes (5) * .github/workflows/test_neo4j.yml * .github/workflows/test_python_3_10.yml * .github/workflows/test_python_3_11.yml * .github/workflows/test_python_3_9.yml * .github/workflows/test_qdrant.yml
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.