toppa / Shashin

A WordPress plugin for displaying photos and videos from Google+, Youtube, and Twitpic
http://www.toppa.com/shashin-wordpress-plugin/
GNU General Public License v3.0
24 stars 10 forks source link

social links break within a random collection. #68

Open rekliner opened 10 years ago

rekliner commented 10 years ago

When linking from a collection of random photos the social links are not returning correctly. When trying to display from the querystring variable shashin_photo_key the shashin photo collection expects to have that image key within it...however if it is a random display (or if the collection was dynamically generated) that key probably won't be in the set and it won't display the picture. One possible solution (and what would fix it for me) would be adding an album_key to every social link even if it wasn't displayed as part of an album. It wouldn't interfere with anything else and it would allow for the social links to be pointed to a catch-all page containing every album.

Otherwise, the only solution I see is to force the loading of that image into a set if shashin_photo_key is present, but that's a pretty clunky way of handling things and wouldn't work well with multiple instances.

BTW, thank you very much for adding the features in issue 49. I was hesitant to ditch all my shashin modifications but you nailed it. This bug is a follow-up to that functionality which I've implemented at my site: http://www.chriskline.com/photos/tour-photo-blog/ ... As described above, I've hardcoded all social links to that page since the random widget display is included on every page in the site....however without changes to the code the random social links are currently broken.