toppev / strike-tab

StrikePractice per player tablist addon.
MIT License
7 stars 2 forks source link

. prefix username over riding the tab rules [BUG] #19

Open Xteri08 opened 5 months ago

Xteri08 commented 5 months ago

Describe the bug A clear and concise description of what the bug is. Basically when a player named .xteri will join tab will sort it at the top in column 1 even tho there was a existing data in that column and there werent any place for a player to be shows To Reproduce Steps to reproduce the behavior:

  1. Install striketab 'latest'
  2. Install geyser or come with a username .username ''
  3. Then 'press tab and see the magic'
  4. See that 'your player name just sorted it self to top even tho it had permission setup for sorting' happens

Expected behavior A clear and concise description of what you expected to happen. The player sorting shouldnt ignore the players with any prefix at all Screenshots, errors and console logs If applicable, add screenshots to help explain your problem. 2024-01-25_17 07 27

If there are any errors in the console, please include them here. Sometimes "/striketab debug" may be helpful in debugging specific problems. [16:59:33 INFO]: [StrikeTab] debug: getLegacyPing failed null ping is the only debug error its spamming Checklist

Versions:

Additional context Add any other context about the problem here. ALso there is another bug This bug is confirmed to be done by striketab 2024-01-25_17 16 34

toppev commented 5 months ago

This seems to happen because StrikeTab only reorders it once someone joins

See https://github.com/toppev/strike-tab/blob/main/src/main/kotlin/RanksManager.kt in case you want to contribute with some additional logic/events to fix this.

About the 001UpdateMC, I'm not sure if that happens without legacy-support too but as far as I remember there was no way to fix the autocomplete player names and it was something outside the plugin control (the MC client)

Xteri08 commented 5 months ago

if i had that much java knowledge i would never create a issue insted i would have a pr request any eta for the fix?