toppev / strikepractice-public

StrikePractice bug tracking and some free resources
2 stars 3 forks source link

[BUG] copypaste not working, erroring out, custom datapack biomes #28

Closed LadyHaley closed 11 months ago

LadyHaley commented 11 months ago

Describe the bug I beleive the plugin gets upset if there is a custom datapack biome either within the existing arena or the location its moving to, im not sure

To Reproduce Steps to reproduce the behavior:

  1. Build an arena in a custom datapack biome
  2. attempt to copypaste the arena
  3. console error

Expected behavior The arena gets copy pasted

Screenshots image

Errors and console logs

[00:08:41 INFO]: LadyHaley issued server command: /arena copypaste basketball
[00:08:44 WARN]: [StrikePractice] Task #40679 for StrikePractice v3.8.1-SNAPSHOT generated an exception
java.lang.IllegalArgumentException: Cannot set the biome to CUSTOM
        at com.google.common.base.Preconditions.checkArgument(Preconditions.java:220) ~[guava-31.1-jre.jar:?]
        at org.bukkit.craftbukkit.v1_20_R1.CraftRegionAccessor.setBiome(CraftRegionAccessor.java:237) ~[paper-1.20.1.jar:git-Paper-196]
        at org.bukkit.craftbukkit.v1_20_R1.block.CraftBlock.setBiome(CraftBlock.java:356) ~[paper-1.20.1.jar:git-Paper-196]
        at ga.strikepractice.arena.a$1.run(ArenaCommand.java:244) ~[strikepractice-3.8.1.jar:?]
        at org.bukkit.craftbukkit.v1_20_R1.scheduler.CraftTask.run(CraftTask.java:101) ~[paper-1.20.1.jar:git-Paper-196]
        at org.bukkit.craftbukkit.v1_20_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:480) ~[paper-1.20.1.jar:git-Paper-196]
        at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1479) ~[paper-1.20.1.jar:git-Paper-196]
        at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:446) ~[paper-1.20.1.jar:git-Paper-196]
        at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1393) ~[paper-1.20.1.jar:git-Paper-196]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1170) ~[paper-1.20.1.jar:git-Paper-196]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:317) ~[paper-1.20.1.jar:git-Paper-196]
        at java.lang.Thread.run(Thread.java:1589) ~[?:?]

Checklist

Versions:

Other plugins AdvancedBan, AdvancedMobArena, ajLeaderboards, ArmorStandAdjustor, ArmorTrimEdit, BanAnnouncer, BannerMaker, BarkBack, BimmCore, BlockEffects, BlockLocker, BlueMap, BlueMap-BannerMarker, BlueMap-Marker, BlueMapSignMarkers, Brewery, ChatColor, Citizens, CitizensCMD, ClearLag, CMILib, CoreProtect, CreeperRecover, CustomCrafting, CustomizablePlayerModels, DamageHolo, DeluxeMentions, DiscordSRV, DiscordSRVUtils, DiscordWhitelister, DropEdit2, DtlPlayershops, dtlTraders, Dualhorse, DurabilityAlert, EasyReferral, eGlow, emotecraft, EnchantGui, EntityTraveller, ExcellentCrates, ExcellentEnchants, ExtractableEnchantments, FastAsyncWorldEdit, FlipCard, FlowerMeal, GCore, Gender, GolfParty, GSit, Harbor, HeadDatabase, HideAndSeek, HolographicDisplays, HoloPlots, HorseChestSaddle, IllegalStack, InteractionVisualizer, InteractiveBooks, InteractiveChat, InteractiveChatDiscordSrvAddon, InvisibleItemFrames, Jobs, LibsDisguises, LoneLibs, Lootin, LuckPerms, Magic, MapModCompanion, MarriageMaster, MCGBluemapEssentialsPlus, McInfected, mcMMO, MiniBoardGames, MinigameMaker, MinionsAndHunger, Multiverse-Core, Multiverse-Inventories, MyPet, MythicMobs, MythicMobsExtension, NexEngine, NoBlackSky, NoteBlockAPI, OreAnnouncer, PacketListenerApi, Paintball, Pazaak, PeacefulPlayerRepacified, PerWorldPlugins, PhantomSpawnControl, PhatLoots, PlaceholderAPI, Plan, PlayerParticles, PlayTime, PlotSquared, PlugManX, ProNouns, ProtectionLib, ProtocolLib, PyroFishingPro, PyroLib, PyroMining, QualityArmory, QualityArmoryVehicles2, QuestCreator, RandomOccurrences, RPGBank, SafeNBT, Sentinel, ServerListPlus, ServerSigns, Shopkeepers, ShulkerRespawner, SkinsRestorer, SmileCore, SpawnerMeta, Spicord, StrikePractice, StripArmour, SunLight, SurvivalGames, Tether, TetrisFriends, TNTRun_reloaded, TogglePvp, VampireRevamp, Vault, ViaBackwards, ViaVersion, Vivecraft-Spigot-Extensions, VoidGen, Votifier, VotingPlugin, WanderingTrades, Werewolf, WolfyUtilities, WorldBorder, WorldEditSelectionVisualizer, WorldGuard, WorldGuardExtraFlags, XConomy, XPBoost, YamipaPlugin

Additional context Add any other context about the problem here.

LadyHaley commented 11 months ago

I used world edit to change the biome in the existing arena to a vanilla one, it resolved the issue, but still a pain to come across lol

toppev commented 11 months ago

Fixed in devbuilds and in next spigot update (it just won't set the biome if it can't so it will still continue copy pasting)