search

topsport-com-au / starlite-saqlalchemy

Starlite API boilerplate abstraction and utilities.
https://topsport-com-au.github.io/starlite-saqlalchemy/
MIT License
31 stars 8 forks source link

bug(sentry): the sentry asgi middleware doesn't really work for us #52

Closed peterschutt closed 1 year ago

peterschutt commented 2 years ago

Need to get the sentry integration task done for starlite org and use that instead.

gazorby commented 1 year ago

Integration is now availble with sdk 1.13.0 released today ;) I think that we should get #213 first what do you think @peterschutt?

peterschutt commented 1 year ago

Yes saw this! Great stuff on that man. That sentry release removes the blocker for sqla RC2 as well!

I think that we should get https://github.com/topsport-com-au/starlite-saqlalchemy/pull/213 first what do you think @peterschutt?

Yep agree totally. That'll be the task that will have the most code churn out of anything else I'd say, so would be good to get it out of the way before much else.

That's blocking on #174 right? I'll make sure the first review I do is #237, sound good?

gazorby commented 1 year ago

That sentry release removes the blocker for sqla RC2 as well! Nice !

That's blocking on https://github.com/topsport-com-au/starlite-saqlalchemy/issues/174 right? I'll make sure the first review I do is https://github.com/topsport-com-au/starlite-saqlalchemy/pull/237, sound good? Sounds good!