search

toptal / active-job-style-guide

This Background Jobs style guide is a list of best practices working with Ruby background jobs.
471 stars 20 forks source link

Update retry section #2

Closed jaimerson closed 4 years ago

pirj commented 4 years ago

This addition is Toptal-specific, and won't apply to general public. This guide was supposed to be open-sourced, let's try to keep it like that.

jaimerson commented 4 years ago

@pirj nevertheless the sidekiq_options retry: 3 does not work. I'm not sure what's the best thing to do

pirj commented 4 years ago

As far as I know, it does work with the latest Sidekiq and https://github.com/rails/rails/releases/tag/v6.0.2 (https://github.com/rails/rails/pull/37214#issuecomment-550431355). Worth double checking though.

pirj commented 4 years ago

I'll close this one, as there's no definitive conclusion and nothing that can be actionable if you don't object.