Removes the retries principle, just because Chewy::Stash::Journal.entries methods as any es query have a limit of default 10 and in case you have more than 100 they are going to be ignored. Instead, pagination is based on the total_count will scan through all entires in the journal.
Another bug is a result of the assumption that entries in the query are sorted by created_at, but in reality, it's not.
As an example imagine the following entries in the journal
This PR fixes two bugs:
Chewy::Stash::Journal.entries
methods as any es query have a limit of default 10 and in case you have more than 100 they are going to be ignored. Instead, pagination is based on thetotal_count
will scan through all entires in the journal.created_at
, but in reality, it's not. As an example imagine the following entries in the journaland the current algorithm step by step
12:00:00
, as a result, entries with ids 1, 3 will be fetched (src)12:04:00
12:04:00
, as a result, we are going have entry withid: 4
onlyThis bug fix is simple, fetch all entries ordered by
created_at
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).