Closed skcc321 closed 1 year ago
@konalegi could you please review this one please? (and trigger the CI)
@konalegi one more time, please. Got failed CI due to no Redis service running.
@skcc321 Thank you very much for the PR, I'll try to review this in a week or find someone who can do it.
@konalegi one more time CI, please (I hope the last one) - fixed linters & ruby 2.x related failed tests.
@konalegi sorry for bothering you. Any updates on that one?
@skcc321, sorry, everyone is busy these days. I'll try to review this on Thursday/Friday, added my Todo list
@mrzasa thank you for the review. I pushed all suggested changes in a separate commit (just for easier review next time). Could you take a look one more time and restart the CI, please? I'll squash all commits when the review is done and there are no more comments.
@konalegi sorry for bothering you, could you please trigger the CI again?
@konalegi @mrzasa any updates?
Thank you @konalegi. I'll work on your comments soon.
@konalegi could you please trigger the CI and look through the latest changes? Thank you
LGTM, please address my last comment and rubocop offense. Thanks for great feature!
@konalegi done. Please take a look at the latest commit.
@mrzasa could approve please (if you have no concerns) :)
Since this PR doesn't modify any existing functionality and brings new feature going to be merge right away. Will be released on Monday
Released
What does it do?
I added a new strategy -
delayed_sidekiq
. It behaves the next way:latency
option (for instance 10 seconds),margin
&reindex_wrapper
margin
option is important to coverreplication_lag
an example:
those three parallel requests that happened during the "latency" window are going to schedule a single worker to call import with all accumulated ids 1, 2, 3
Strategy option in #import method.
Accumulation of :update_fields option between chunks.
will cause
that can be very useful if you have some complex crutches in the index definition and you don't want to load the database with obviously useless SQL queries.
Configuration
at
CityIndex
levelBefore submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).