toptal / chewy

High-level Elasticsearch Ruby framework based on the official elasticsearch-ruby client
MIT License
1.88k stars 366 forks source link

Replace bypass strategy description with one that better describes behaviour #876

Closed RobNicholsGDS closed 1 year ago

RobNicholsGDS commented 1 year ago

The current description of the bypass strategy uses the phrase "simply silences index updates" to describe the bypass strategy. I think this is misleading as doing something silently doesn't mean that a process does not happen but rather that there is no output. If I select a process to happen silently, I would expect a normal behaviour but without anything being logged or output to the console.

I believe that the bypass strategy does more than simply suppress output. Instead it bypasses the index update on model save.

konalegi commented 1 year ago

Thanks for improvement!