toptal / chewy

High-level Elasticsearch Ruby framework based on the official elasticsearch-ruby client
MIT License
1.88k stars 366 forks source link

Port PR #874 to the 7.0.x branch #885

Open cguess opened 1 year ago

cguess commented 1 year ago

As with #874 Ruby 3 doesn't expand keyword arguments. Unfortunately I'm still stuck on ES 6.8. Is it possible to backport this fix?

Expected behavior

Retain the same previous, non-crashing behavior

Actual behavior

A crash when running bundle exec rails chewy:reset

Error log:

** Invoke chewy:reset (first_time)
** Invoke environment (first_time)
** Execute environment
** Execute chewy:reset
rake aborted!
ArgumentError: wrong number of arguments (given 1, expected 0)
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/chewy-7.0.1/lib/chewy/rake_helper.rb:39:in `reset'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/chewy-7.0.1/lib/tasks/chewy.rake:26:in `block (2 levels) in <top (required)>'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:281:in `block in execute'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:281:in `each'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:281:in `execute'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:219:in `block in invoke_with_call_chain'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:199:in `synchronize'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:199:in `invoke_with_call_chain'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/task.rb:188:in `invoke'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/application.rb:160:in `invoke_task'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/application.rb:116:in `block (2 levels) in top_level'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/application.rb:116:in `each'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/application.rb:116:in `block in top_level'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/application.rb:125:in `run_with_threads'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/application.rb:110:in `top_level'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/application.rb:83:in `block in run'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/application.rb:186:in `standard_exception_handling'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/application.rb:80:in `run'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
/Users/christopher/.rbenv/versions/3.1.4/bin/rake:25:in `load'
/Users/christopher/.rbenv/versions/3.1.4/bin/rake:25:in `<top (required)>'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/bundler-2.2.33/lib/bundler/cli/exec.rb:58:in `load'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/bundler-2.2.33/lib/bundler/cli/exec.rb:58:in `kernel_load'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/bundler-2.2.33/lib/bundler/cli/exec.rb:23:in `run'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/bundler-2.2.33/lib/bundler/cli.rb:479:in `exec'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/bundler-2.2.33/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/bundler-2.2.33/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/bundler-2.2.33/lib/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/bundler-2.2.33/lib/bundler/cli.rb:31:in `dispatch'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/bundler-2.2.33/lib/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/bundler-2.2.33/lib/bundler/cli.rb:25:in `start'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/bundler-2.2.33/exe/bundle:49:in `block in <top (required)>'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/bundler-2.2.33/lib/bundler/friendly_errors.rb:103:in `with_friendly_errors'
/Users/christopher/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/bundler-2.2.33/exe/bundle:37:in `<top (required)>'
/Users/christopher/.rbenv/versions/3.1.4/bin/bundle:25:in `load'
/Users/christopher/.rbenv/versions/3.1.4/bin/bundle:25:in `<main>'
Tasks: TOP => chewy:reset

Steps to reproduce the problem

Have version 7.0.1 installed with Ruby 3 and run bundle exec rails chewy:reset

Version Information

Share here essential version information such as: