search

toptal / chewy

High-level Elasticsearch Ruby framework based on the official elasticsearch-ruby client
MIT License
1.88k stars 366 forks source link

Warning when upgrading to Rails 7.1 #903

Closed yoLotus closed 9 months ago

yoLotus commented 10 months ago

Expected behavior

I'm upgrading my app to Rails 7.1 and I have a deprecation warning message that seems to be triggered by chewy.

Actual behavior

This warning is displayed when running my testing suite:

DEPRECATION WARNING: Bolding log text with a positional boolean is deprecated and will be removed in Rails 7.2. Use an option hash instead (eg. `color("my text", :red, bold: true)`).

Steps to reproduce the problem

The warning is triggered by the line located (here)

As recommended by the warning message, the warning is not displayed if we move the line to:

action = color(action, GREEN, bold: true)

Regarding the doc, the support is supported until Rails 6.1, is there any plan for the newly Rails release?

I'm taking the opportunity of this message to thank you for this gem.

Version Information