search

toptal / crystalball

Regression Test Selection library for your RSpec test suite
https://toptal.github.io/crystalball/
MIT License
322 stars 41 forks source link

Explicitly require forwardable in SourceDiff #107

Closed kbruccoleri closed 5 years ago

kbruccoleri commented 5 years ago

Resolves the following issue when running bundle exec crystalball (with bunder 2.0.1, ruby 2.4.5)

bundler: failed to load command: crystalball (/Users/kevin.bruccoleri/.rbenv/versions/2.4.5/lib/ruby/gems/2.4.0/bin/crystalball) NameError: uninitialized constant Crystalball::SourceDiff::Forwardable /Users/kevin.bruccoleri/code/crystalball/lib/crystalball/source_diff.rb:10:in <class:SourceDiff>' /Users/kevin.bruccoleri/code/crystalball/lib/crystalball/source_diff.rb:8:in' /Users/kevin.bruccoleri/code/crystalball/lib/crystalball/source_diff.rb:6:in <top (required)>' /Users/kevin.bruccoleri/code/crystalball/lib/crystalball/git_repo.rb:4:inrequire' /Users/kevin.bruccoleri/code/crystalball/lib/crystalball/git_repo.rb:4:in <top (required)>' /Users/kevin.bruccoleri/code/crystalball/lib/crystalball.rb:4:inrequire' /Users/kevin.bruccoleri/code/crystalball/lib/crystalball.rb:4:in <top (required)>' /Users/kevin.bruccoleri/code/crystalball/bin/crystalball:4:inrequire' /Users/kevin.bruccoleri/code/crystalball/bin/crystalball:4:in <top (required)>' /Users/kevin.bruccoleri/.rbenv/versions/2.4.5/lib/ruby/gems/2.4.0/bin/crystalball:23:inload' /Users/kevin.bruccoleri/.rbenv/versions/2.4.5/lib/ruby/gems/2.4.0/bin/crystalball:23:in `<top (required)>'

Envek commented 5 years ago

+1 on this, faced it while tried to install crystalball to existing application (Ruby 2.6.3, Bundler 2.0.1).

Forwardable is in Ruby's stdlib, not core, so you have to require 'forwardable' to get it.

pluff commented 5 years ago

CI build is green https://travis-ci.org/toptal/crystalball/builds/500008661 Thanks, merged.