search

toptal / crystalball

Regression Test Selection library for your RSpec test suite
https://toptal.github.io/crystalball/
MIT License
322 stars 41 forks source link

Allow excluding certain source files from mapping #131

Closed rodrigovilina closed 3 years ago

rodrigovilina commented 3 years ago

THIS IS STILL MAINLY A DRAFT

A proposal on filtering source files as per suggested on the example in issue #118.

As I suggested there, I think it would be more granular and cleaner to implement if this exclusion was at each strategy level rather than at the MapGenerator level. Also each strategy could be dealt with one at a time, making review easier.

I'll leave comments on what could be simplified with this approach and what parts are ugly and will be refactored once we decide further course of action.

Since this is just a draft I haven't made any test already; I tested it locally (only on coverage strategy) by vendoring the gem and testing on some code that actually called also vendored rspec gem. Test will be my starting point for any further advancement.

I'll expect some type of response before continuing development.

pirj commented 3 years ago

Thanks for the PR! I suggest summoning @jaimerson @EPecherkin and @pluff as reviewers.

rodrigovilina commented 3 years ago

I'm picking this up again!

hebertdougl commented 2 years ago

Hi @vaporyhumo, do we have any news here?

rodrigovilina commented 2 years ago

Actually no, I switched jobs (I'm at toptal now :laughing:) and don't need this anymore. I can give it a try if it useful for anyone else tho. We can pair on it too if you want. :ear: