toptal / database_validations

Database validations for ActiveRecord
MIT License
530 stars 13 forks source link

Improve benchmarks code #25

Closed pirj closed 5 years ago

pirj commented 5 years ago

The benchmarks were not properly normalized, and for some reason 'each hundredth' was significantly faster than 'only existing' for *belongs_to.

The order of 'with gem'/'without gem' was not consistent across benchmarks.

The order optimistic-realistic-pessimistic was not consistent across benchmarks.

djezzzl commented 5 years ago

Thank you 👍 I'll update charts soon