search

toptensoftware / RichTextKit

Rich text rendering for SkiaSharp
Other
361 stars 74 forks source link

Added a property for FontWidth #46

Closed charlenni closed 2 years ago

charlenni commented 2 years ago

Added a property in IStyle (and everywhere else) for FontWidth (as normal, condensed and expanded)

toptensoftware commented 2 years ago

This looks like a nice change but can we use SKFontStyleWidth instead of introducing a new enum. The other RichTextKit enums on IStyle are only there because there's no SkiaSharp equivalent. Since we're exposing SKColor, we might as well use SKFontStyleWidth too.

charlenni commented 2 years ago

Thank you for looking into this.

Yes, we can, and it is a very good idea. So the code is much shorter and more readable. Thank you for the tip.