search

toptensoftware / VBoxHeadlessTray

Run a VirtualBox machine in a tray icon
180 stars 23 forks source link

New installer fails on 32-bit OS due to x64-only constant #18

Open GreenReaper opened 8 years ago

GreenReaper commented 8 years ago

When starting to install the 5.0 executable on 32-bit Windows Vista, I received the following error

Cannot expand "pf64" constant on this version of Windows.

This behaviour is documented. You probably want to use {pf} instead.

The actual program works fine when extracted with innounp.

PranavMahesh1 commented 7 years ago

@GreenReaper Did you get this program working on 32-bit?

GreenReaper commented 7 years ago

No; I took the raw drive which held the VM out and put it in a HP MicroServer Gen8 instead. Worked a treat!

ShadowEO commented 5 years ago

Same issue here, attempting to install the version for 5.2 (32-bit OS locked in by firmware, so I can't install a 64-bit OS and run Vbox6) gives the same error.

It appears that the reason is this line: #define InstallDir "{pf64}\Topten Software\VBoxHeadlessTray" should be #define InstallDir "{pf}\Topten Software\VBoxHeadlessTray" as {pf} should (iirc, it's been a little bit since i've used inno) automatically resolve to the C:\Program Files directory on a 64-bit capable system anyway, or at least go to the (x86) folder, which will still be correct for installation for an application that mixes architecture support like this one.

That should fix the installer's 32-bit crashing, and really shouldn't cause any issues with the application otherwise..