tor2web / Tor2web

Tor2web is an HTTP proxy software that enables access to Tor Hidden Services by mean of common web browsers
https://www.tor2web.org
GNU Affero General Public License v3.0
705 stars 176 forks source link

obviated need for invalid_hostname.tpl #248

Closed virgil closed 8 years ago

virgil commented 9 years ago

I realized that everytime I was showing the invalid_hostname template all I wanted was the user to go back to the front page. So I skipped a step and we have one less template to think about.

landscape-bot commented 9 years ago

Code Health Repository health decreased by 33% when pulling f13d91e on virgil:patch-5 into 09dc22e on globaleaks:master.

landscape-bot commented 9 years ago

Code Health Code quality remained the same when pulling 08c1358 on virgil:patch-5 into 09dc22e on globaleaks:master.

evilaliv3 commented 9 years ago

mmm got the point in the case of onion.city, but what about tor2web.org in general? @fpietrosanti ?

in addition in the case of tor2web.org in general (where we still block crawlers) there is a big issue; if we make the crawlers subject to the banner, the crawler will think the page exists even if the HS does not exists anymore, due to the fact that the acceptance page is shown before making any kind of request to the hidden service. @fpietrosanti what do you think about this issue? crawlers would penalize tor2web for pointing a lot, even not existing pages to the same acceptance page.

virgil commented 9 years ago

This isn't outputting the content of the frontpage, it is redirecting to the frontpage. The former is spammy behavior, the latter is not. Just do a 301 redirect.

evilaliv3 commented 9 years ago

yep virgil i see what you sai in relation to onion.city.

the issue would be with tor2web software in generale that does not have an homepage but we could design it to point simply to www+ config.basehost or something.

and for the issue i was saying, @fpietrosanti probably befor showing the disclaimer we should anyway make a requeste to the hidden service requiring simply the "/" in order to test if the page exists or not (this would also speed up things by opening the circuit; so we exploit the time the user opens the page to automatically opening the sock.

virgil commented 8 years ago

Yeah @evilaliv3 makes sense.