search

toradex / torizon-samples

All sample code related to TorizonCore project.
The Unlicense
32 stars 24 forks source link

Add generic VPU example #15

Closed embdur closed 9 months ago

embdur commented 10 months ago

Signed-off-by: Abdur Rehman abdur.rehman@toradex.com

leonheldattoradex commented 10 months ago

Is there any reason to include the source code of linux-imx-headers instead of using https://feeds.toradex.com/debian/pool/non-free/l/linux-imx-headers/?

leonheldattoradex commented 10 months ago

My comments are mostly infrastructure-related, and I'm not the gatekeeper for this branch, so I'll just leave my comments at that. I have a bunch of reservations regarding how the samples are structured (repetition and non-portability of pwsh scripts, sharing key pairs for ssh) but these are not related to the MR.

embdur commented 10 months ago

@leonheldattoradex

Is there any reason to include the source code of linux-imx-headers instead of using https://feeds.toradex.com/debian/pool/non-free/l/linux-imx-headers/?

Oh my, that's a chonky left over from an experiment. I will remove it.

leograba commented 9 months ago

Guys, I lost track of this a bit. Is there anything blocking?

embdur commented 9 months ago

Fixed issues around linux-imx-headers and gpg key. Now rebasing against latest default template.

embdur commented 9 months ago

Sanity testing: Tested the sample on all three supported targets(verdin-imx8mm , verdin-imx8mp and apalis-imx8.

embdur commented 9 months ago

Added .conf/.template manually to the base template commit.

andreriesco commented 9 months ago

LGTM

microhobby commented 2 months ago

non-portability of pwsh scripts

I was handling the https://github.com/toradex/vscode-torizon-templates/issues/155 and saw your comment here. I do not get what you mean by this. Could you please give an example @leonheldattoradex ?