toradex / vscode-torizon-templates

VS Code Torizon Integrated Development Environment Templates
MIT License
15 stars 20 forks source link

All templates: task apply-torizon-packages as dependency of build-container-torizon-* and build-image-sdk-* #149

Closed griloHBG closed 9 months ago

griloHBG commented 9 months ago

Before, apply-torizon-packages was dependency of run-* and deploy-* tasks. This way, one needed to run or deploy the application to update the related Dockerfiles with the last modification done on torizonPackages.json.

With this modification, the build process of the containers will depend on the apply-torizon-packages, therefore it will take into account modifications done on torizonPackages.json without the need to run or deploy the application.

microhobby commented 9 months ago

LGTM

@andreriesco could you also check?

andreriesco commented 9 months ago

I just that the apply torizon packages step on the Dockerfiles of the Rust console and rust slint templates are missing.

@microhobby, do you know if there is a reason for the Rust templates not to have them?

# your regular RUN statements here
# Install required packages
RUN apt-get -q -y update && \
    apt-get -q -y install \
# DO NOT REMOVE THIS LABEL: this is used for VS Code automation
    # __torizon_packages_prod_start__
    # __torizon_packages_prod_end__
# DO NOT REMOVE THIS LABEL: this is used for VS Code automation
    && apt-get clean && apt-get autoremove && \
    rm -rf /var/lib/apt/lists/*
microhobby commented 9 months ago

I just that the apply torizon packages step on the Dockerfiles of the Rust console and rust slint templates are missing.

@andreriesco please open an issue about this, since this is not related to the scope of this MR.

andreriesco commented 9 months ago

Sure, I just realized it was already there, at #121

andreriesco commented 9 months ago

LGTM