toranb / ember-cli-simple-store

ember-cli addon that provides a simple identity map for ember.js web applications
MIT License
67 stars 14 forks source link

Change how dependent keys are registered on isDirty computed property #75

Closed jasonmit closed 7 years ago

jasonmit commented 7 years ago

@toranb thanks for writing kick ass tests, helped me get to the bottom of this pretty quickly.

We were relying on the functionality that changed here: https://github.com/emberjs/ember.js/pull/13231

This is to fix ember-beta and ember-canary (and is completely backwards compat.)

toranb commented 7 years ago

@jasonmit wow excellent find and fix! Much appreciated :)