toranb / ember-data-django-rest-adapter

An ember-data adapter for django web applications powered by the django-rest-framework
MIT License
152 stars 26 forks source link

consolidates pushSinglePayload and pushArrayPayload into pushP... #62

Closed craigteegarden closed 10 years ago

craigteegarden commented 11 years ago

...ayload. This also allows it to be used through the store's pushPayload.

This PR is a rebased on master version of this original PR: https://github.com/toranb/ember-data-django-rest-adapter/pull/53

This will fix issue #51.

This requires a pull request on ember-data to be pulled: https://github.com/emberjs/data/pull/1474

toranb commented 10 years ago

@craigteegarden looks like this might get merged into ember-data core soon :)

craigteegarden commented 10 years ago

I am excited to have this finally wrapped up!! On Jan 8, 2014 10:11 PM, "Toran Billups" notifications@github.com wrote:

@craigteegarden https://github.com/craigteegarden looks like this might get merged into ember-data core soon :)

— Reply to this email directly or view it on GitHubhttps://github.com/toranb/ember-data-django-rest-adapter/pull/62#issuecomment-31899307 .

toranb commented 10 years ago

Any word on this issue w/ ember-data core? (just looking to wrap up some of these long lived issues if possible)

craigteegarden commented 10 years ago

we're still waiting on https://github.com/emberjs/data/pull/1474 but it seems like it could get merged in soon.

dustinfarris commented 10 years ago

It looks like the ember-data change is DOA. @craigteegarden is there another way we can do this?

craigteegarden commented 10 years ago

From the discussion it looks like a new method on the store has been added: store.normalize().

This might let us finally get this functionality integrated -- I will look at how to update this to match the new store.normalize().