search

toranb / ember-template-compiler

An npm module for the ember-template-compiler.js file that ships with ember.js
MIT License
30 stars 23 forks source link

Added updated Ember compiler v1.0.0-rc.6 #1

Closed jimbol closed 11 years ago

jimbol commented 11 years ago

I needed to update this, so I figured I'd share.

toranb commented 11 years ago

Awesome! thanks for the pull request -does this require the latest (security fixed RC 6 1 or is this just RC 6 pre security fix?)

Thanks!

jimbol commented 11 years ago

Hmm, I'm not sure. I pulled this from 1.0.0-rc.6.1 but I dont believe its is incompatible with anything. We are running RC 3 (for the time being) and it works fine.

toranb commented 11 years ago

What version did you use w/ ember.js RC6.1 when you noticed it was broken? I just pulled down RC6.1 and had no issue using the latest version of ember-template-compiler from npm

https://github.com/toranb/ember-testing-example

You can test it w/ the above app, just clone it, npm install, bower install (notice it works fine w/ RC 5 from bower). Go to the ember website and pull down the latest js file RC 6.1 and test it -notice it works w/ out any error

What kind of issue did you have? could you host the file you had issue with? Could you download the latest version of this from npm and the latest RC from the ember website and see if you still have issues?

Thanks for taking a look into this, but I haven't found an issue with this on OSX 10.8.4 running node 0.10.15

jimbol commented 11 years ago

No issues, just wanted to make sure it was up to date. I'm building a middleware file, I'll create a separate pull request for that.  ​ Either way this is the latest compiler. You'll see the changes aren't significant.  

— Sent from Mailbox for iPhone

On Tue, Aug 13, 2013 at 7:13 PM, Toran Billups notifications@github.com wrote:

What version did you use w/ ember.js RC6.1 when you noticed it was broken? I just pulled down RC6.1 and had no issue using the latest version of ember-template-compiler from npm https://github.com/toranb/ember-testing-example You can test it w/ the above app, just clone it, npm install, bower install (notice it works fine w/ RC 5 from bower). Go to the ember website and pull down the latest js file RC 6.1 and test it -notice it works w/ out any error What kind of issue did you have? could you host the file you had issue with? Could you download the latest version of this from npm and the latest RC from the ember website and see if you still have issues?

Thanks for taking a look into this, but I haven't found an issue with this on OSX 10.8.4 running node 0.10.15

Reply to this email directly or view it on GitHub: https://github.com/toranb/ember-template-compiler/pull/1#issuecomment-22607121

jimbol commented 11 years ago

The changes in this pull request that is.  — Sent from Mailbox for iPhone

On Tue, Aug 13, 2013 at 7:13 PM, Toran Billups notifications@github.com wrote:

What version did you use w/ ember.js RC6.1 when you noticed it was broken? I just pulled down RC6.1 and had no issue using the latest version of ember-template-compiler from npm https://github.com/toranb/ember-testing-example You can test it w/ the above app, just clone it, npm install, bower install (notice it works fine w/ RC 5 from bower). Go to the ember website and pull down the latest js file RC 6.1 and test it -notice it works w/ out any error What kind of issue did you have? could you host the file you had issue with? Could you download the latest version of this from npm and the latest RC from the ember website and see if you still have issues?

Thanks for taking a look into this, but I haven't found an issue with this on OSX 10.8.4 running node 0.10.15

Reply to this email directly or view it on GitHub: https://github.com/toranb/ember-template-compiler/pull/1#issuecomment-22607121

toranb commented 11 years ago

After pulling this in I realized that my template compiler js file actually has handlebars embedded inside of it so I had to re-do it using the latest RC 6.1 code.

I did get this working, and published a new version to npm but during that process I found handlebars 1.0.0 is broken in regular ember.js and in my apps I had to use 1.0-rc4 (getting a replace of undefined error that's currently open on github)

If you run into this, you can still use this precompiler for testing / etc, but what's not tested (and might be broken) is if you mix / match this + handlebars compiling in client side JS code using 1.0.0

This module does work stand alone for something like compiling templates for karma so I can unit test them using QUnit (updated the karma-ember-preprocessor after this and it works great with RC 6.1 code)

I'll leave this issue closed, but when the team gets a working version with handlebars 1.0.0 I may need to update it again (sorry for the delay but it looks like ember core is a mess right now for some reason)

jimbol commented 11 years ago

Thanks for the update.  — Sent from Mailbox for iPhone

On Tue, Aug 13, 2013 at 11:41 PM, Toran Billups notifications@github.com wrote:

After pulling this in I realized that my template compiler js file actually has handlebars embedded inside of it so I had to re-do it using the latest RC 6.1 code. I did get this working, and published a new version to npm but during that process I found handlebars 1.0.0 is broken in regular ember.js and in my apps I had to use 1.0-rc4 (getting a replace of undefined error that's currently open on github) If you run into this, you can still use this precompiler for testing / etc, but what's not testing (and might be broken) is if you mix / match this + handlebars compiling in client side JS code using 1.0.0 This module does work stand alone for something like compiling templates for karma so I can unit test them using QUnit (updated the karma-ember-preprocessor after this and it works great with RC 6.1 code)

I'll leave this issue closed, but when the team gets a working version with handlebars 1.0.0 I may need to update it again (sorry for the delay but it looks like ember core is a mess right now for some reason)

Reply to this email directly or view it on GitHub: https://github.com/toranb/ember-template-compiler/pull/1#issuecomment-22614691