search

toranb / ember-template-compiler

An npm module for the ember-template-compiler.js file that ships with ember.js
MIT License
30 stars 23 forks source link

Require node >= 0.8.19. #15

Closed rwjblue closed 8 years ago

rwjblue commented 10 years ago

This project is using peerDependencies to ensure that the Handlebars dependency is setup properly (and can be overridden by our consumers). In practice this works wonderfully, but a few users with older Node.js and/or NPM versions simple get a broken build. This is because Node.js < 0.8.19 did not have the ability to handle peerDependencies specified in the package.json.

This changes to ensure that at least 0.8.19 (well over a year old) is used, and provides the user with a reasonable error message (indicating that their Node.js version is too old).

If this is unacceptable, we could attempt to detect this upon first use, and fail loudly if Handlebars is not found.

@toranb - I opened this up as a PR to make sure we are on the same page on this. Are you OK with requiring 0.8.19+?

toranb commented 10 years ago

I think this is more than reasonable -our 0.8.x projects are now using >= 25 last time I checked anyway :)

toranb commented 10 years ago

What does this mean? "engineStrict": true

rwjblue commented 10 years ago

@toranb - I removed engineStrict just now. It means that installation would fail if this was not met.

rwjblue commented 10 years ago

I removed it because if you had installed Handlebars in your projects package.json file, it would work perfectly fine for us at least down to 0.8.0 (and possibly lower).

I'm on the fence on the engineStrict option. On one hand 0.8.19 is over a year old, and anything less likely has known issues anyways; but on the other hand, I would hate to break someones app on next deploy because they haven't updated their Node.js version...

@toranb - Totally your call, what would you prefer?

toranb commented 10 years ago

If anything I say we take it up a bit - 0.8.24 ? its still 0.8 friendly -just more patches ? no?

toranb commented 9 years ago

@rwjblue any update on this boss? can we still do >= 0.8.25 ? Most of my projects today are 0.10.x