toranb / ember-template-compiler

An npm module for the ember-template-compiler.js file that ships with ember.js
MIT License
30 stars 23 forks source link

block style components in subdirectories #19

Closed mattmarcum closed 10 years ago

mattmarcum commented 10 years ago

{{my-cmp/subcmp}} works just fine in an ember-cli setup at least

but {{#my-cmp/subcmp}}test{{/my-cmp/subcmp}} doesn't compile...

broccoli error msg is:

Build failed.
Cannot read property '1' of null

I haven't stepped through the code yet, I was wondering if anyone had already fixed this problem. Would really like to group my components together to keep my components folder organized and namespaced better.

I posted this issue on discuss too here: http://discuss.emberjs.com/t/components-in-subdirectories-with-ember-cli/5960

mattmarcum commented 10 years ago

the line that is failing is in vendor/ember-template/compiler.js@213

  var helperName = (DOT_LOOKUP_REGEX.exec(helperInvocation) || BRACKET_STRING_LOOKUP_REGEX.exec(helperInvocation))[1];
mattmarcum commented 10 years ago

I saw this discussion so I'll close this

https://github.com/stefanpenner/ember-cli/issues/1219