search

toranb / ember-template-compiler

An npm module for the ember-template-compiler.js file that ships with ember.js
MIT License
30 stars 23 forks source link

Consider dropping "-beta" #20

Closed ftokarev closed 9 years ago

ftokarev commented 9 years ago

grunt-ember-templates specifies its dependency on ember-template-compiler the following way:

"ember-template-compiler": ">=1 <2"

This causes issues if npm 2 is used:

npm ERR! peerinvalid The package ember-template-compiler does not satisfy its siblings' peerDependencies requirements! npm ERR! peerinvalid Peer grunt-ember-templates@0.4.21 wants ember-template-compiler@>=1 <2

Because npm 2 uses semver 4: semver.satisfies('1.7.0-beta.1', '>=1 <2'); // false

toranb commented 9 years ago

Any reason we shouldn't rename / bump this to remove the beta now @rwjblue ?

aoberoi commented 9 years ago

bump

toranb commented 9 years ago

I'm still not sure what @rwjblue has to say but ... I'm willing to bet that next week when 1.8 ships we might get a 1.8 (non beta) compiler (correct me if I'm wrong)

rwjblue commented 9 years ago

Correct

aoberoi commented 9 years ago

@toranb @rwjblue thanks.

rwjblue commented 9 years ago

Released 1.7.0.

toranb commented 9 years ago

Did you also publish 1.7 to npm? I see 1.9 is the latest on npm (just wanted to see if I could update my other (stable) projects to use 1.7.0 specifically)

rwjblue commented 9 years ago

@toranb - Yep, 1.7.0 is on NPM. This should get it:

npm install ember-template-compiler@1.7.0
toranb commented 9 years ago

So will 1.7.0 be the "best stable option" to use when ember 1.8 (stable) is released this week?

rwjblue commented 9 years ago

I'll plan to release a 1.8.0 when I ship Ember 1.8.0.

rwjblue commented 9 years ago

But they are basically the same (template compiler wise).