search

toranb / ember-template-compiler

An npm module for the ember-template-compiler.js file that ships with ember.js
MIT License
30 stars 23 forks source link

Added the latest changes from ember 1.1.1 #3

Closed garth closed 10 years ago

toranb commented 10 years ago

Thanks for the PR - does ember.js 1.1.1 require or use a newer version of handlebars than ember.js 1.0 ?

toranb commented 10 years ago

The reason I ask is that currently the starter kit still ships with handlebars 1.0

https://github.com/emberjs/starter-kit

Have you found an issue w/ the original compiler that I haven't yet come across?

garth commented 10 years ago

Handlebars is stil at 1.0.0. Also Ember 1.1.2 has been release, but that doesn't affect handlebars rendering.

I had lots of problems when upgrading from 1.0 to 1.1 and during the course of investigation I upgraded this lib to be sure that it wasn't the culprit.

The most important change is that ember no longer allows component templates without a hyphen (-) and that check is now included in this compiler.

toranb commented 10 years ago

You make a great point -I forgot that 50% of this project is built from the version of ember.js itself. I'll rebuild the compiler today using ember.js 1.1.2 and handlebars 1.0 (is it okay if I deny this PR and push up something that works with the latest stable release?)

toranb commented 10 years ago

I just upgraded the compiler to use the one that ships with ember.js 1.1.2 (the diff looks identical to your changes so we are good regardless). I'm not sure what project you are using with this but be sure to note the version number will now match the version of ember.js (previous it was 0.0.6 -> it's now 1.1.2)