search

toranb / ember-template-compiler

An npm module for the ember-template-compiler.js file that ships with ember.js
MIT License
30 stars 23 forks source link

Update for ember 1.10 #30

Closed dwickern closed 9 years ago

dwickern commented 9 years ago

This updates to the template compiler from emberjs 1.10 (now HTMLBars).

I use this project in my SBT plugin and I'd like to support ember 1.10

toranb commented 9 years ago

@rwjblue should we bump this library to 2.0 or something to keep ember-cli apps working /support people in the community who need this 1.10 update for other apps (non cli based) they are supporting?

rwjblue commented 9 years ago

@toranb - As of Ember 1.10+ you should be using the specific template compiler that is built and matched to the version of Ember that you are running. Basically, this package is no longer a reasonable thing (because it is not possible to keep it matching the running Ember version unless we also vendor Ember itself and force consumers to use it) as of 1.10.

I wrote more about this on the Ember Blog a while back: emberjs.com/blog/2015/02/05/compiling-templates-in-1-10-0.html

toranb commented 9 years ago

@dwickern it sounds like you might have better luck w/ a fork of this project. At this time I don't think it would be advised to include ember w/ this dependency as @rwjblue suggested.