search

toranb / ember-template-compiler

An npm module for the ember-template-compiler.js file that ships with ember.js
MIT License
30 stars 23 forks source link

Update to Ember 1.2.0. #4

Closed rwjblue closed 10 years ago

toranb commented 10 years ago

Awesome ! thanks for keeping this up to date -just to be clear, this includes handlebars @ the top (embedded) and the compiler JS on the bottom (that way you can just include this single dependency)

rwjblue commented 10 years ago

Gotcha, was just working through why the tests failed...

rwjblue commented 10 years ago

Are you opposed to using peer dependencies? The handlebars package is being well maintained, and I think this makes it a bit easier to manage various ember-template-compiler versions along side various handlebars versions.

I think that the resulting API would be exactly the same.

rwjblue commented 10 years ago

I have updated this PR to use peerDependencies, this allows us to defer the actual Handlebars version to be used to consumer packages (or uses the latest supported if they do not specify).

If you are completely opposed to this change I will revert, and embed as you had originally.