search

torandreroland / homebridge-sony-audio-control

Sony Audio Control of STR-DN1080 for Homebridge: https://github.com/nfarina/homebridge
ISC License
12 stars 10 forks source link

Refactoring by MaxiHuHe04 #6

Closed torandreroland closed 3 years ago

torandreroland commented 4 years ago

@MaxiHuHe04: Thank you for your wonderful work with refactoring the plugin and also doing some bug fixes and adding the ability configure the maximum volume. Can I pull your changes into my project (and subsequently publish a new version to NPM)?

MaxiHuHe04 commented 3 years ago

Hi! Sorry for the late reply. You already merged it anyways, but yes, it's okay. However, I only own an STR-DN860. So I'm not 100% sure if I have broken a compatibility somewhere. Have you already tested my fork with the STR-DN1080?

torandreroland commented 3 years ago

Sorry for merging before you okay'ed it, @MaxiHuHe04.

I tried your code with my STR-DN1080 receiver and noticed some defects / regressions (mostly related to turning off other soundfields when changing soundfield and getting power state). As your code is much cleaner than mine, I was eager to fix the regressions and therefore I merged the pull request.

Than you again for your excellent work with refactoring the code and using more modern technologies / frameworks.