torbencarstens / CocktailParty-Frontend

Frontend for open cocktail database
http://opencocktail.party
MIT License
0 stars 1 forks source link

Design for the cocktail detail site #1

Open torbencarstens opened 6 years ago

torbencarstens commented 6 years ago

Current design:

image

Possible changes

FelixGail commented 6 years ago

I think the ingredient parameters have to be explained or used in a sentence. For example:


Ingredients

for 1 portion of 300 ml

torbencarstens commented 6 years ago

Like this? image

This is live on 1a231f41aceedb7262eb8bddbb29475652d37599

FelixGail commented 6 years ago

looks good. i would also make the ingredient table have the left column right aligned and the right column left alinged and switch name and amount

torbencarstens commented 6 years ago

Basically like this? image

I've added a todo list into the original comment.

The change is live. Somehow throws a 404 on reloading the detail site (doesn't happen locally with my nginx config, will look into this when the routing is finished)

BjoernPetersen commented 6 years ago

Shouldn't the full cocktail description be below the ingredients and instructions?

torbencarstens commented 5 years ago

screencapture-localhost-1234-cocktail-0-2018-12-23-19_49_13

The instructions part is now auto generated. The short description is a link. Do we want to add some sort of Continue here at the end of the short description?

Where should the rating go?