torbennehmer / hacs-e3dc

Homeassistant E3DC Integration
GNU Affero General Public License v3.0
53 stars 8 forks source link

Support for multiple batteries #123

Closed thijsdewitt closed 2 months ago

thijsdewitt commented 3 months ago

Checklist

Is your feature request related to a problem? Please describe.

I'm not sure if this should be a bug report or an enhancement.

Configuring 1 battery in HA works great. But as soon as I configure the second, the data gets merged. The graphs look identical with a bunch of spikes. So I assume multiple batteries are not supported.

data when 1 battery is configured: Scherm­afbeelding 2024-03-19 om 11 50 09

data when 2 batteries are configured: Scherm­afbeelding 2024-03-19 om 11 50 15

My hardware is 2x S10E_Pro

Describe the solution you'd like

Support for multiple batteries

Describe alternatives you've considered

Running with only 1 battery configured

Additional context

No response

Diagnostics dump

No response

torbennehmer commented 3 months ago

@thijsdewitt You mean you have two independant e3dc unit each with its own IP address?

thijsdewitt commented 3 months ago

Yes, exactly

torbennehmer commented 3 months ago

Actually, I have never thought about that possibility, something that's inherently hard to judge for me. I assumed, that one won't have two E3DCs simultaneously.

Honestly, I'm right now very unsure, what happens here. I'd assume, that you have to configure the integration twice, but what happens from there, I don't know.

Do you have any python experience?

thijsdewitt commented 3 months ago

No python experience, but I do have programming experience. I already got the project running locally, just tinkering with the python debugger and setting up my local environment

thijsdewitt commented 3 months ago

Still properly testing this, will report back tomorrow when I have solar production data

torbennehmer commented 3 months ago

@thijsdewitt I'll look into it later, I'm rather busy over Easter. If you want, we can disucss this directly, German or English, as you want. Just contact me directly via torben nehmer net in this case.

thijsdewitt commented 3 months ago

No rush, let's discuss this after the holidays.

torbennehmer commented 2 months ago

@thijsdewitt Thanks for the PR: Out of curiosity, could you give me the diagnostic dumps from your end (I assume that you get two off them, one for each instance of the integration)?

torbennehmer commented 2 months ago

I'm just pushing a second change, I've the suspicion, that you might have additional trouble, the ed3c proxy uses statics as well. I'll fix that in a minute, so if you pull dumps, please wait for that fix. Apparently, I still have to learn a few of the details of Python :)

thijsdewitt commented 2 months ago

config_entry-e3dc_rscp-5616b5c127cad10ae66d5cab94add41c.json config_entry-e3dc_rscp-c4dfb7633b67d92fa0805a41e95290f7.json