Update build flags to support other enviornments

torch-points3d / torch-points-kernels

Pytorch kernels for spatial operations on point clouds

MIT License

96 stars 24 forks source link

Update build flags to support other enviornments #63

Closed CCInc closed 3 years ago

CCInc commented 3 years ago

I allowed the user to specify environmental variables similar to https://github.com/rusty1s/pytorch_sparse/blob/master/setup.py

This is similar to #60 but will be more versatile for building in docker containers etc.

Let me know your thoughts!

nicolas-chaulet commented 3 years ago

Looks great thanks for the addition! The CI is failing at the moment, could you please force Numpy version to be strcitly less than 1.20? There is an incompatibility with Numba. This should be in the CI pipeline as well as in the setup.py file. Thanks!

CCInc commented 3 years ago

@nicolas-chaulet looks like CI is happy, let me know if you need anything else 👍 We can probably close #60 with this PR as well.