search

torch / argcheck

A powerful (and blazing fast) argument checker and function overloading system for Lua or LuaJIT
Other
54 stars 17 forks source link

bugs wrt order of arguments and defaults #1

Closed soumith closed 10 years ago

soumith commented 10 years ago

I found two bugs. Both can be reproduced with this gist: https://gist.github.com/c10bc2ad64e5facccf7d

Bug 1: If you run the gist as is, you will see that "split" is given the value of 90 (which is default), even though it is sent split=15 in the constructor. I noticed that if you interchange lines 12 <-> 13, this bug goes away

Bug 2: The gist as is will give the output: { split : 90 paths : { 1 : ../../toyset } sampleSize : { 1 : 3 2 : 100 3 : 100 } }

However, if you remove line 10, you will get the output: { sampleSize : { split : 15 paths : { 1 : ../../toyset } sampleSize : { 1 : 3 2 : 100 3 : 100 } } split : 90 }

Notice that inside of sampleSize, there is now a member variable split: 15, apart from the last line having a split: 90

andresy commented 10 years ago

Your rules are ambiguous: both ordered argument call initcheck(table) and named argument call initcheck{paths=table} are valid. You can avoid this by forcing noordered=true.

The next version (in graph branch) gives an error in such cases.